ci: tighten action-smoke assertion to exact no-bump values#12
Merged
Conversation
`test -n` (non-empty) passed on any string, including a CLI status leaking past action.yml's normalization (`no_merge_commit`, `no_conforming_commit`, etc.). Tighten to exact equality: status="no-bump", bump="none", tag empty. Failures now surface regressions instead of being papered over by any-non-empty.
lesnik512
force-pushed
the
bugfix/tighten-smoke-assertion
branch
from
6071699 to
2435c38
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per the final reviewer of #10: replace
test -n(non-empty) with exact-equality assertions so regressions inaction.yml's status normalization orbumpenum drift surface loudly instead of passing silently.Before:
After:
Test plan